On 8/19/19 1:55 PM, Max Reitz wrote: > We currently refuse to open qcow2 images with overly long snapshot > tables. This patch makes qemu-img check -r all drop all offending > entries past what we deem acceptable. > > Signed-off-by: Max Reitz <mre...@redhat.com> > --- > block/qcow2-snapshot.c | 88 +++++++++++++++++++++++++++++++++++++----- > 1 file changed, 78 insertions(+), 10 deletions(-)
I know I was reluctant in v1, but you also managed to convince me that it really takes a LOT of effort to get a table with that many entries. And a user has to opt-in to 'qemu-img -r' (it may discard a snapshot they value, but that beats not being able to use the image under qemu at all, and we don't erase it for plain 'qemu-img check'). So I'm okay with this going in. Maybe the commit message can state this sort of reasoning. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
