On Tue, Aug 20, 2019 at 08:12:51PM +0200, Max Reitz wrote: > On 14.08.19 22:22, Maxim Levitsky wrote: > > While there are other places where these are still stored in memory, > > this is still one less key material area that can be sniffed with > > various side channel attacks > > > > > > > > (Many empty lines here) > > > Signed-off-by: Maxim Levitsky <mlevi...@redhat.com> > > --- > > crypto/block-luks.c | 52 ++++++++++++++++++++++++++++++++++++++------- > > 1 file changed, 44 insertions(+), 8 deletions(-) > > Wouldn’t it make sense to introduce a dedicated function for this?
Yes, it would. In fact I have a series pending which bumps min glib and introduces use of auto-free functions in this code. It would be desirable to have a autp-free func for memset+free so we can just declare the variable q_autowipefree char *password = NULL; and have it result in memset+free Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
