On 8/23/19 8:28 AM, Richard Henderson wrote: > On 8/23/19 3:07 AM, David Hildenbrand wrote: >> While the CONFIG_USER_ONLY variant can handle multiple pages (no MMU), the >> !CONFIG_USER_ONLY variant can't and won't. We'll want to convert >> probe_write() to return a host address (similar to tlb_vaddr_to_host()) >> soon. This only works on page granularity. >> >> Signed-off-by: David Hildenbrand <da...@redhat.com> >> --- >> accel/tcg/cputlb.c | 2 ++ >> 1 file changed, 2 insertions(+) > > As I just mentioned in the previous, I think the two implementations should > match. > > Anyway, the "multiple pages" thing above still means exactly two, since if > there were three pages involved we were only probing two of them, and the > third > could still be unmapped.
Oh, but the actual code here, is fine. Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~