On 8/25/19 10:28 AM, Richard Henderson wrote: >> CPS shouldn't exist at all for M-profile, but the legacy decoder >> got this wrong too, so we should put that on the todo list for >> fixing later (along, maybe, with UNDEFing on some of the >> unpredictable combinations of M/imod/etc for A profile?). > Fixing m-profile is just as easy as as commenting. > I'll leave a TODO for the unpredictable combinations.
There's also a missing check for ARMv6 here. That got added later, with the T16 decode. I have just added the following to the T16 commit message: target/arm: Convert T16, Change processor state Add a check for ARMv6 in trans_CPS. We had this correct in the T16 path, but had previously forgotten the check on the A32 and T32 paths. r~