On 24.08.19 12:07, Vladimir Sementsov-Ogievskiy wrote: > It's wrong to OR shared permissions. It may lead to crash on further > permission updates. > Also, no needs to consider previously calculated permissions, as at > this point we already bind all new parents and bdrv_get_cumulative_perm > result is enough. So fix the bug by just set permissions by > bdrv_get_cumulative_perm result. > > Bug was introduced in long ago 234ac1a9025, in 2.9. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > --- > > Hi all! > > I found this bug during my work around backup-top filter. It happens that > on filter removing, bdrv_replace_node() breaks permissions in graph which > lead to bdrv_set_backing_hd(new backing: NULL) on > assert(tighten_restrictions == false). > > block.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-)
Thanks, that makes sense. Applied to my block branch: https://git.xanclic.moe/XanClic/qemu/commits/branch/block Max
signature.asc
Description: OpenPGP digital signature
