On 2019-08-26 10:21, Maxim Levitsky wrote: > On Mon, 2019-08-26 at 02:29 +0200, Kővágó, Zoltán wrote: >> pa_context_new expects a client name, not a server socket path. >> >> Signed-off-by: Kővágó, Zoltán <dirty.ice...@gmail.com> >> --- >> audio/paaudio.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/audio/paaudio.c b/audio/paaudio.c >> index bfef9acaad..777b8e4718 100644 >> --- a/audio/paaudio.c >> +++ b/audio/paaudio.c >> @@ -866,7 +866,7 @@ static void *qpa_conn_init(const char *server) >> } >> >> c->context = pa_context_new(pa_threaded_mainloop_get_api(c->mainloop), >> - server); >> + "qemu"); >> if (!c->context) { >> goto fail; >> } > > Also tested, and this works. > > May I suggest though to make this configurable as well, for the sake of > usability since gnome sound settings show only the client name, and it > is per each sound card. > Although on the other thing the client name is qemu.
There is a small problem with that. Currently we only open one connection to pa, even with multiple -audiodevs (they will just create different streams), which means we can only use a single client name per qemu process. Because of that, I wouldn't turn this into an audiodev property. Some other kind of global setting could work, but I'm not sure whether it's worth it or not. Regards, Zoltan > > Reviewed-by: Maxim Levitsky <mlevi...@redhat.com> > > Best regards, > Maxim Levitsky > >