On Sat, Aug 24, 2019 at 12:28:13PM -0500, Eric Blake wrote: > A server may have a reason to reject a request for structured replies, > beyond just not recognizing them as a valid request; similarly, it may > have a reason for rejecting a request for a meta context. It doesn't > hurt us to continue talking to such a server; otherwise 'qemu-nbd > --list' of such a server fails to display all available details about > the export. > > Encountered when temporarily tweaking nbdkit to reply with > NBD_REP_ERR_POLICY. Present since structured reply support was first > added (commit d795299b reused starttls handling, but starttls is > different in that we can't fall back to other behavior on any error). > > Signed-off-by: Eric Blake <ebl...@redhat.com> > --- > nbd/client.c | 63 +++++++++++++++++++++++++----------------------- > nbd/trace-events | 2 +- > 2 files changed, 34 insertions(+), 31 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
