Patchew URL: https://patchew.org/QEMU/20190827082427.64280-1-sam...@google.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190827082427.64280-1-sam...@google.com Type: series Subject: [Qemu-devel] [PATCH v6 0/8] Add Qemu to SeaBIOS LCHS interface === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' ae278de hd-geo-test: Add tests for lchs override 715cfa8 bootdevice: FW_CFG interface for LCHS values 54cd6e4 bootdevice: Refactor get_boot_devices_list 381ba9d bootdevice: Gather LCHS from all relevant devices f16e5f7 scsi: Propagate unrealize() callback to scsi-hd 12bf34c bootdevice: Add interface to gather LCHS fa36200 block: Support providing LCHS from user 3acc0a3 block: Refactor macros - fix tabbing === OUTPUT BEGIN === 1/8 Checking commit 3acc0a31ae55 (block: Refactor macros - fix tabbing) ERROR: Macros with complex values should be enclosed in parenthesis #55: FILE: include/hw/block/block.h:65: +#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf) \ + DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0), \ + DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0), \ DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0) total: 1 errors, 0 warnings, 37 lines checked Patch 1/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/8 Checking commit fa36200c8ceb (block: Support providing LCHS from user) 3/8 Checking commit 12bf34c38eb5 (bootdevice: Add interface to gather LCHS) 4/8 Checking commit f16e5f7d73f7 (scsi: Propagate unrealize() callback to scsi-hd) 5/8 Checking commit 381ba9d8d879 (bootdevice: Gather LCHS from all relevant devices) 6/8 Checking commit 54cd6e409022 (bootdevice: Refactor get_boot_devices_list) 7/8 Checking commit 715cfa8c4ab1 (bootdevice: FW_CFG interface for LCHS values) 8/8 Checking commit ae278de99d62 (hd-geo-test: Add tests for lchs override) WARNING: Block comments use a leading /* on a separate line #641: FILE: tests/hd-geo-test.c:996: + "skipping hd-geo/override/* tests"); total: 0 errors, 1 warnings, 609 lines checked Patch 8/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190827082427.64280-1-sam...@google.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com