On 29.08.19 01:16, Richard Henderson wrote: > We have already aligned page2 to the start of the next page. > There is no reason to do that a second time. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > accel/tcg/cputlb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c > index 7fb67d2f05..d0f8db33a2 100644 > --- a/accel/tcg/cputlb.c > +++ b/accel/tcg/cputlb.c > @@ -1518,8 +1518,7 @@ store_helper(CPUArchState *env, target_ulong addr, > uint64_t val, > entry2 = tlb_entry(env, mmu_idx, page2); > tlb_addr2 = tlb_addr_write(entry2); > if (!tlb_hit_page(tlb_addr2, page2) > - && !victim_tlb_hit(env, mmu_idx, index2, tlb_off, > - page2 & TARGET_PAGE_MASK)) { > + && !victim_tlb_hit(env, mmu_idx, index2, tlb_off, page2)) { > tlb_fill(env_cpu(env), page2, size2, MMU_DATA_STORE, > mmu_idx, retaddr); > } >
Reviewed-by: David Hildenbrand <da...@redhat.com> -- Thanks, David / dhildenb