On Thu, Aug 29, 2019 at 03:41:20PM +0100, Alex Bennée wrote: > The recent podman changes (9459f754134bb) imported enum which is part > of the python3 standard library but only available as an external > library for python2. This causes problems on the fairly restricted > environment such as shippable. Lets bite the bullet and make the > script a fully python3 one. To that end: > > - drop the from __future__ import (we are there now ;-) > - avoid the StringIO import hack > - be consistent with the mode we read/write dockerfiles > - s/iteritems/items/ > - ensure check_output returns strings for processing > > Signed-off-by: Alex Bennée <alex.ben...@linaro.org> > Cc: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > tests/docker/docker.py | 27 ++++++++++++++------------- > 1 file changed, 14 insertions(+), 13 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|