Stefan Hajnoczi <stefa...@gmail.com> writes:

> On Thu, Aug 29, 2019 at 06:50:27PM +0200, Sergio Lopez wrote:
>>      case VIRTIO_MMIO_QUEUE_PFN:
>> +        if (!proxy->legacy) {
>> +            qemu_log_mask(LOG_GUEST_ERROR,
>> +                "%s: read from legacy register (0x%lx) in non-legacy 
>> mode\n",
>> +                __func__, offset);
>
> Please use HWADDR_PRIx since offset has type hwaddr.  On ILP32 and LLP64
> hosts %lx is only 32-bit.

Ack.

Thanks!
Sergio.

> Otherwise:
>
> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>

Attachment: signature.asc
Description: PGP signature

Reply via email to