We have to mask of any unused bits. While at it, document what exactly is
missing.
Signed-off-by: David Hildenbrand <da...@redhat.com>
---
target/s390x/mem_helper.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index a763482ae0..947a4277f0 100644
--- a/target/s390x/mem_helper.c
+++ b/target/s390x/mem_helper.c
@@ -680,8 +680,15 @@ uint32_t HELPER(mvpg)(CPUS390XState *env, uint64_t r0,
uint64_t r1, uint64_t r2)
s390_program_interrupt(env, PGM_SPECIFICATION, ILEN_AUTO, GETPC());
}
- /* ??? missing r0 handling, which includes access keys, but more
- importantly optional suppression of the exception! */
+ r1 = wrap_address(env, r1 & TARGET_PAGE_MASK);
+ r2 = wrap_address(env, r2 & TARGET_PAGE_MASK);
+
+ /*
+ * TODO:
+ * - Access key handling
+ * - CC-option with surpression of page-translation exceptions
+ * - Store r1/r2 register identifiers at real location 162
+ */
fast_memmove(env, r1, r2, TARGET_PAGE_SIZE, GETPC());
return 0; /* data moved */
}
--
2.21.0
