On Tue, 2019-09-10 at 16:49 +0200, Paolo Bonzini wrote: > On 09/09/19 19:03, John Snow wrote: > > > > > > On 9/9/19 5:25 AM, Max Reitz wrote: > > > On 05.09.19 19:27, John Snow wrote: > > > > > > [...] > > > > > > > You also probably require review (or at least an ACK) from Keith Busch > > > > who maintains this file. > > > > > > Keith actually maintains the NVMe guest device; technically, Fam is the > > > NVMe block driver maintainer. > > > > W h o o p s. Thanks for correcting me. > > > > Well, if it's Fam -- he seems a little busier lately -- it's probably > > not so crucial to gate on his approval. I thought it'd be nice to at > > least get an ACK from someone who has used this module before, because I > > haven't -- I was just giving some style review to help push it along. > > > > (On that note, if you felt like my style review was wrong or isn't worth > > doing -- it is always perfectly fair to just say so, along with some > > reason as to why you won't -- that way patches won't rot on the list > > when people may have gotten the impression that a V2 is warranted.) Absolutely not, your review was fine! I just was/is a bit lazy to send next version of the patches before I get some kind of indication if anything else is needed for this to be merged, since the module doesn't have currently an active maintainer.
> > Looks good to me with the changes you pointed out (especially res30; > leaving out the unused macros is not so important). All right, I'll send an updated version of those two patches soon. Best regards, Maxim Levitsky