Patchew URL: https://patchew.org/QEMU/20190917122644.15736-1-johan...@sipsolutions.net/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC] contrib: add vhost-user-sim Message-id: 20190917122644.15736-1-johan...@sipsolutions.net Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20190917122644.15736-1-johan...@sipsolutions.net -> patchew/20190917122644.15736-1-johan...@sipsolutions.net Switched to a new branch 'test' e897496 contrib: add vhost-user-sim === OUTPUT BEGIN === WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #73: new file mode 100644 WARNING: line over 80 characters #254: FILE: contrib/vhost-user-sim/cal.c:170: + if (running_entry && entry != running_entry && running_entry->update_until) { ERROR: line over 90 characters #257: FILE: contrib/vhost-user-sim/cal.c:173: + DPRINT("update %s to be free until %lld (due to add unless of %s)\n", running_entry->name, nexttime, entry->name); ERROR: line over 90 characters #260: FILE: contrib/vhost-user-sim/cal.c:176: + DPRINT("no update for running entry %s\n", running_entry ? running_entry->name : "<none>"); ERROR: line over 90 characters #278: FILE: contrib/vhost-user-sim/cal.c:194: + DPRINT("update %s to be free until %lld (due to add of %s)\n", running_entry->name, nexttime, entry->name); ERROR: line over 90 characters #281: FILE: contrib/vhost-user-sim/cal.c:197: + DPRINT("no update for running entry %s\n", running_entry ? running_entry->name : "<none>"); WARNING: line over 80 characters #525: FILE: contrib/vhost-user-sim/main.c:96: + printf("Usage: %s -s time-device-socket [-n net-device-socket] | [ -h ]\n", ERROR: braces {} are necessary for all arms of this statement #547: FILE: contrib/vhost-user-sim/main.c:118: + if (net_socket) [...] ERROR: line over 90 characters #741: FILE: contrib/vhost-user-sim/net.c:156: + fprintf(stderr, "insert IRQ from %s at %lld\n", ndev->entry.name, calendar_get_time()); WARNING: line over 80 characters #951: FILE: contrib/vhost-user-sim/simtime.c:114: + DPRINT(" %d | calendar entry added for %lld\n", conn->idx, msg->time); WARNING: line over 80 characters #954: FILE: contrib/vhost-user-sim/simtime.c:117: + DPRINT(" %d | calendar entry time updated for %lld\n", conn->idx, msg->time); ERROR: line over 90 characters #980: FILE: contrib/vhost-user-sim/simtime.c:143: + g_assert(full_write(g_io_channel_unix_get_fd(conn->chan), &resp, sizeof(resp)) == sizeof(resp)); ERROR: line over 90 characters #981: FILE: contrib/vhost-user-sim/simtime.c:144: + DPRINT(" %d | sent ACK for message %s (%lld, time %lld)\n", conn->idx, simtime_op_str(msg->op), msg->op, msg->time); ERROR: line over 90 characters #991: FILE: contrib/vhost-user-sim/simtime.c:154: + g_assert(full_write(g_io_channel_unix_get_fd(conn->chan), msg, sizeof(*msg)) == sizeof(*msg)); ERROR: line over 90 characters #993: FILE: contrib/vhost-user-sim/simtime.c:156: + g_assert(full_read(g_io_channel_unix_get_fd(conn->chan), msg, sizeof(*msg)) == sizeof(*msg)); ERROR: braces {} are necessary for all arms of this statement #996: FILE: contrib/vhost-user-sim/simtime.c:159: + if (msg->op == UM_TIMETRAVEL_ACK) [...] ERROR: line over 90 characters #1043: FILE: contrib/vhost-user-sim/simtime.c:206: + printf("client disconnected, made %lld requests and waited %lld times, sent %lld updates\n", ERROR: do not use C99 // comments #1048: FILE: contrib/vhost-user-sim/simtime.c:211: + // leak for now ... source is still attached ERROR: do not use C99 // comments #1049: FILE: contrib/vhost-user-sim/simtime.c:212: + //g_free(conn); total: 14 errors, 5 warnings, 1127 lines checked Commit e89749692cba (contrib: add vhost-user-sim) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190917122644.15736-1-johan...@sipsolutions.net/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com