On Thu, 09/12 19:07, John Snow wrote: > > > On 9/11/19 9:52 PM, no-re...@patchew.org wrote: > > Patchew URL: > > https://patchew.org/QEMU/20190912014442.5757-1-js...@redhat.com/ > > > > > > > > Hi, > > > > This series seems to have some coding style problems. See output below for > > more information: > > > > Subject: [Qemu-devel] [PATCH] docker: add sanitizers back to clang build > > Message-id: 20190912014442.5757-1-js...@redhat.com > > Type: series > > > > === TEST SCRIPT BEGIN === > > #!/bin/bash > > git rev-parse base > /dev/null || exit 0 > > git config --local diff.renamelimit 0 > > git config --local diff.renames True > > git config --local diff.algorithm histogram > > ./scripts/checkpatch.pl --mailback base.. > > === TEST SCRIPT END === > > > > From https://github.com/patchew-project/qemu > > * [new tag] patchew/20190912014442.5757-1-js...@redhat.com -> > > patchew/20190912014442.5757-1-js...@redhat.com > > Switched to a new branch 'test' > > 96d44b9 docker: add sanitizers back to clang build > > > > === OUTPUT BEGIN === > > ERROR: Missing Signed-off-by: line(s) > > GDI. > > I keep adding this to my configuration files, but it keeps "falling > off", somehow. > > I have some patches in the works for stgit where I'm going to work > through some test cases for setting profile variables and try to fix this. > > In the meantime: > > Signed-off-by: John Snow <js...@redhat.com>
Isn't this because you inserted a '---' line in the middle of the commit message so the part after it is ditched by 'git am'? This feels a bit hard to catch, wondering what is in the works. :) Fam
