On Thu, 2019-09-19 at 11:03 +0100, Stefan Hajnoczi wrote: > On Wed, Sep 18, 2019 at 11:19:28PM +0000, Oleinik, Alexander wrote: > > #ifdef CONFIG_COCOA > > #undef main > > This looks suspicious. Should the #ifdef CONFIG_COCOA be moved into > main.c?
> The return value is confusing. 0 = success, >0 error exit code, but > the > function may also invoke exit(0) to terminate successfully. > > It's simpler to make this function void and invoke exit(3) directly. I'll make these changes. Thanks
