On 9/23/19 4:34 PM, Peter Maydell wrote: > On Sat, 21 Sep 2019 at 16:04, Thomas Huth <th...@redhat.com> wrote: >> >> We are going to make CONFIG_ARM_V7M optional, so the related cortex-m >> CPUs should only be created if the switch is enabled. This can best >> be done if the code resides in a separate file, thus move the related >> functions to a new file v7m.c which only gets compiled if CONFIG_ARM_V7M >> is enabled. >> >> Signed-off-by: Thomas Huth <th...@redhat.com> >> --- >> target/arm/Makefile.objs | 1 + >> target/arm/cpu.c | 146 ----------------------------- >> target/arm/v7m.c | 193 +++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 194 insertions(+), 146 deletions(-) >> create mode 100644 target/arm/v7m.c > > Calling the new file something with 'cpu' in it would help > to convey that it does the same kinds of things as > cpu.c and cpu64.c. Maybe cpu-m.c or cpu-v7m.c ?
I agree to your other comment: From a CONFIG switch point of view I don't think it's worth being able to #ifdef out the various flavours of M-profile individually. So I'm in favor of using cpu-m.c.
