On Tue, 24 Sep 2019 11:47:51 +0200 Philippe Mathieu-Daudé <phi...@redhat.com> wrote:
> On 9/24/19 6:59 AM, David Gibson wrote: > > The XICS interrupt controller device used to have separate subtypes > > for the KVM and non-KVM variant of the device. That was a bad idea, > > because it leaked information that should be entirely host-side > > implementation specific to the kinda-sorta guest visible QOM class > > names. > > > > We eliminated the KVM specific class some time ago, but it's left > > behind a distinction between the TYPE_ICS_BASE abstract class and > > TYPE_ICS_SIMPLE subtype which no longer serves any purpose. > > > > This series collapses the two types back into one. > > > > David Gibson (4): > > xics: Eliminate 'reject', 'resend' and 'eoi' class hooks > > xics: Merge reset and realize hooks > > xics: Rename misleading ics_simple_*() functions > > xics: Merge TYPE_ICS_BASE and TYPE_ICS_SIMPLE classes > > Please remove the qemu_register_reset() call in hw/intc/xics.c, No. This is needed because the XICS devices don't sit in a bus and dc->reset doesn't get called by anyone. > then for the series: > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> >