On Tue, Sep 24, 2019 at 1:05 PM G 3 <programmingk...@gmail.com> wrote:
> On top > > > Message: 9 >> Date: Tue, 24 Sep 2019 10:56:53 -0000 >> From: Adrian Vladu <avl...@cloudbasesolutions.com> >> To: qemu-devel@nongnu.org >> Subject: [Bug 1826175] Re: Compilation on MSYS2/MinGW-w64 fails with >> error: "No rule to make target capstone.lib" >> Message-ID: >> < >> 156932261321.27303.8940310087786694778.mal...@soybean.canonical.com> >> Content-Type: text/plain; charset="utf-8" >> >> The fix in upstream capstone has been merged: >> >> https://github.com/aquynh/capstone/commit/29893c63e34ee21846744d02c396ae3c801b936b >> >> -- >> You received this bug notification because you are a member of qemu- >> devel-ml, which is subscribed to QEMU. >> https://bugs.launchpad.net/bugs/1826175 >> >> Title: >> Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make >> target capstone.lib" >> >> Status in QEMU: >> New >> >> Bug description: >> I submitted this bug to Capstone directly but I figured it'd be useful >> to post it here too. The IS_MINGW check in the Makefile for Capstone >> fails under MSYS2 MinGW-w64 because cc --version doesn't have mingw in >> the output anymore: >> >> $ whereis cc >> cc: /mingw64/bin/cc.exe >> >> $ cc --version >> cc.exe (Rev2, Built by MSYS2 project) 8.3.0 >> Copyright (C) 2018 Free Software Foundation, Inc. >> This is free software; see the source for copying conditions. There is >> NO >> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR >> PURPOSE. >> >> Really simple patch: >> >> diff --git "a/Makefile" "b/Makefile" >> index 063f50db..1d9f042e 100644 >> --- "a/Makefile" >> +++ "b/Makefile" >> @@ -288,7 +288,7 @@ CFLAGS := $(CFLAGS:-fPIC=) >> # On Windows we need the shared library to be executable >> else >> # mingw? >> -IS_MINGW := $(shell $(CC) --version | grep -i mingw | wc -l) >> +IS_MINGW := $(shell $(CC) --version | grep -i msys2 | wc -l) >> ifeq ($(IS_MINGW),1) >> EXT = dll >> AR_EXT = lib >> >> To manage notifications about this bug go to: >> https://bugs.launchpad.net/qemu/+bug/1826175/+subscriptions >> >> ******************************************** >> > Hi Peter, could we make capstone disabled by default please? It does cause compiling problems and isn't needed to use QEMU.
