On Tue, Sep 24, 2019 at 04:06:02PM +0200, Cédric Le Goater wrote: > On 24/09/2019 13:41, David Gibson wrote: > > On Tue, Sep 24, 2019 at 07:31:44AM +0200, Cédric Le Goater wrote: > >> On 24/09/2019 06:59, David Gibson wrote: > >>> TYPE_ICS_SIMPLE is the only subtype of TYPE_ICS_BASE that's ever > >>> instantiated, and the only one we're ever likely to want. The > >>> existence of different classes is just a hang over from when we > >>> (misguidedly) had separate subtypes for the KVM and non-KVM version of > >>> the device. > >>> > >>> So, collapse the two classes together into just TYPE_ICS. > >> > >> > >> Well, I have been maintaining another subclass for the PHB3 MSI > >> but it has never been merged and it will require some rework. > > > > Well, if you did do this again, is there an actual need for it to be a > > subclass of ICS_BASE, and not ICS_SIMPLE? AFAICT the merged ICS class > > should be fine for pnv as well. > > the reject resend handlers might be an issue. Anyhow, let's merge this > cleanup. PHB3 has been out of tree for too long.
Hrm, are you sure. I remember thinking the other day "whatever
happened to that PHB3 patchset?". Is it actually broken, or has it
just been a long time since it was posted, and therefore been
forgotten by me.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
