On 9/24/19 11:25 AM, Alex Bennée wrote:
>> -
>> - /* The backing page may or may not require I/O. */
>> - tlb_addr &= ~TLB_WATCHPOINT;
>> - if ((tlb_addr & ~TARGET_PAGE_MASK) == 0) {
>> - goto do_aligned_access;
>> - }
>> }
>>
> /* We don't apply MO_BSWAP to op here because we want to
> * ensure the compiler can always unfold and dead-code away
> * the final load_memop in the fast path. If you try the
> * you will find the assert will get you ;-)
> */
I added
+ /*
+ * Keep these two load_memop separate to ensure that the compiler
+ * is able to fold the entire function to a single instruction.
+ * There is a build-time assert inside to remind you of this. ;-)
+ */
r~
