On 26/09/2019 14.20, Thomas Huth wrote: > On 26/09/2019 13.33, Claudio Imbrenda wrote: >> Return the correct error code when the SCCB buffer is too small to >> contain all of the output, for the Read SCP Information and >> Read CPU Information commands. >> >> Signed-off-by: Claudio Imbrenda <imbre...@linux.ibm.com> >> Reviewed-by: Jason J. Herne <jjhe...@linux.ibm.com> >> --- >> hw/s390x/sclp.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c >> index 76feac8..8f7fe1c 100644 >> --- a/hw/s390x/sclp.c >> +++ b/hw/s390x/sclp.c >> @@ -68,6 +68,11 @@ static void read_SCP_info(SCLPDevice *sclp, SCCB *sccb) >> >> read_info->ibc_val = cpu_to_be32(s390_get_ibc_val()); >> >> + if (sccb->h.length < (sizeof(ReadInfo) + cpu_count * sizeof(CPUEntry))) >> { > > Don't you need a cpu16_to_cpu() around sccb->h.length?
I meant be16_to_cpu(), obviously. Thomas