On Fri, 2019-09-27 at 11:15 +0100, Daniel P. Berrangé wrote:
> On Thu, Sep 26, 2019 at 12:35:15AM +0300, Maxim Levitsky wrote:
> > * rename the write_func to create_write_func,
> > and init_func to create_init_func
> > this is preparation for other write_func that will
> > be used to update the encryption keys.
> >
> > No functional changes
> >
> > Signed-off-by: Maxim Levitsky <mlevi...@redhat.com>
> > Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>
> > ---
> > block/crypto.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/block/crypto.c b/block/crypto.c
> > index 7eb698774e..6e822c6e50 100644
> > --- a/block/crypto.c
> > +++ b/block/crypto.c
> > @@ -78,7 +78,7 @@ struct BlockCryptoCreateData {
> > };
> >
> >
> > -static ssize_t block_crypto_write_func(QCryptoBlock *block,
> > +static ssize_t block_crypto_create_write_func(QCryptoBlock *block,
> > size_t offset,
> > const uint8_t *buf,
> > size_t buflen,
>
> The parameters need re-indenting when you change this name.
I am just blind thats all :-(
I checked all the patches for the indention and still missed it :-(
Will do of course.
Best regards,
Maxim Levitsky
>
> > @@ -96,8 +96,7 @@ static ssize_t block_crypto_write_func(QCryptoBlock
> > *block,
> > return ret;
> > }
> >
> > -
> > -static ssize_t block_crypto_init_func(QCryptoBlock *block,
> > +static ssize_t block_crypto_create_init_func(QCryptoBlock *block,
> > size_t headerlen,
> > void *opaque,
> > Error **errp)
>
> And here
>
> I dropped this one from the pull request, so please bundle it into your
> other luks series
>
> Regards,
> Daniel
