On 05/20/2011 05:53 PM, Christoph Hellwig wrote:
qbus_create_inplace(&bus->qbus,&scsi_bus_info, host, NULL); > bus->busnr = next_scsi_bus++; > bus->tcq = tcq; > bus->ndev = ndev; > - bus->complete = complete; > + bus->ops = *ops;Normally bus->ops would be a pointer, so you can just assign it to the address passed in instead of doing a copy. Any good reason to do it differently here?
I was thinking that they could be modified in-place later, or built on the stack depending on some qdev properties, but it's probably pointless to do it differently. Will change.
Paolo
