On 02/10/2019 18.44, Kevin Wolf wrote: > Not sure where in this thread to reply, but since my name is mentioned > in this mail, it might at least be not the worst one. > > Am 02.10.2019 um 13:57 hat Max Reitz geschrieben: >> On 02.10.19 06:46, Thomas Huth wrote: >>> On 01/10/2019 20.44, Max Reitz wrote: >>> [...] >>>> As I have said, the conceptual problem is that the iotests now run as >>>> part of make check. As such, allowing auto tests to run on non-Linux >>>> platforms may introduce build failures that I cannot do anything about. >>> >>> Well, simply run "make vm-build-openbsd", "make vm-build-freebsd", ... >>> if something fails there, it likely should not be in the auto group. >> >> Then we come to Windows and macOS. >> >> What I’ve proposed to John on IRC was to simply skip the iotests in make >> check for non-Linux systems. > > I think this really makes sense. Or at least have a blacklist of OSes > that we can't support iotests on, which would contain at least Windows > and OS X. Windows because I'm pretty sure that it doesn't work anyway, > and OS X because if something fails there, we have no way to reproduce.
Both, .travis.yml and .cirrus-ci.yml have a macOS test, so you can reproduce bugs there. It's just a PITA that you cannot do any interactive debugging there. [...] > Can we run tests in 'auto' that require the system emulator? Yes. In fact, tests/check-block.sh explicitly checks for the availability of a system emulator before running the iotests. > If so, let's add 030 040 041 to the default set. Sure, but let's check whether they work in Travis first. Thomas
signature.asc
Description: OpenPGP digital signature