On 10/4/19 8:43 AM, Stefan Brankovic wrote: > In previous implementation, invocation of TCG shift function could request > shift of TCG variable by 64 bits when variable 'sh' is 0, which is not > supported in TCG (values can be shifted by 0 to 63 bits). This patch fixes > this by using two separate invocation of TCG shift functions, with maximum > shift amount of 32. > > Name of variable 'shifted' is changed to 'carry' so variable naming > is similar to old helper implementation. > > Variables 'avrA' and 'avrB' are replaced with variable 'avr'. > > Fixes: 4e6d0920e7547e6af4bbac5ffe9adfe6ea621822 > Reported-by: Paul Clark <p...@us.ibm.com>
Preferred: "Paul A. Clarke" (for historical consistency) > Reported-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> > Suggested-by: Aleksandar Markovic <aleksandar.marko...@rt-rk.com> > Signed-off-by: Stefan Brankovic <stefan.branko...@rt-rk.com> Applying this patch on top of dce5a787c05fe1a3e54d92871cdeba2af6798e0d eliminated the failures that I reported in https://bugs.launchpad.net/qemu/+bug/1841990 associated with vsl/vsr. Tested-by: Paul A. Clarke <p...@us.ibm.com> PC
