On 9/16/19 7:15 AM, Peter Maydell wrote: > In arm_gdb_syscall() we have a comment suggesting a race > because the syscall completion callback might not happen > before the gdb_do_syscallv() call returns. The comment is > correct that the callback may not happen but incorrect about > the effects. Correct it and note the important caveat that > callers must never do any work of any kind after return from > arm_gdb_syscall() that depends on its return value. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > I'll come back to do the cleanup later, but I preferred > not to tangle it up with the rest of the refactoring in > this series; I also think it's probably easier done > afterwards rather than before. > --- > target/arm/arm-semi.c | 19 +++++++++++++++---- > 1 file changed, 15 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~
