On 10/7/19 7:35 PM, John Snow wrote:
On 10/7/19 8:33 AM, Peter Maydell wrote:
On Thu, 3 Oct 2019 at 20:33, John Snow <js...@redhat.com> wrote:
The following changes since commit 7f21573c822805a8e6be379d9bcf3ad9effef3dc:
Merge remote-tracking branch
'remotes/huth-gitlab/tags/pull-request-2019-10-01' into staging (2019-10-01
13:13:38 +0100)
are available in the Git repository at:
https://github.com/jnsnow/qemu.git tags/ide-pull-request
for you to fetch changes up to f6d61c9509c56eea3cdd2d23b40d285601b1c1ca:
hd-geo-test: Add tests for lchs override (2019-10-03 14:36:54 -0400)
----------------------------------------------------------------
Pull request V2
- Added signoff into the mirrored commits themselves (vs just the email)
- Kudos to `stg-foreach stg edit --sign`
----------------------------------------------------------------
Hi; the new tests in hd-geo-test seem to hang on
big-endian hosts (both s390x and ppc64 hung here):
linux1@lxub05:~/qemu/build/all$ QTEST_QEMU_IMG=./qemu-img
QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64
./tests/hd-geo-test
/x86_64/hd-geo/ide/none: OK
/x86_64/hd-geo/ide/drive/cd_0: OK
/x86_64/hd-geo/ide/drive/mbr/blank: OK
/x86_64/hd-geo/ide/drive/mbr/lba: OK
/x86_64/hd-geo/ide/drive/mbr/chs: OK
/x86_64/hd-geo/ide/device/mbr/blank: OK
/x86_64/hd-geo/ide/device/mbr/lba: OK
/x86_64/hd-geo/ide/device/mbr/chs: OK
/x86_64/hd-geo/ide/device/user/chs: OK
/x86_64/hd-geo/ide/device/user/chst: OK
/x86_64/hd-geo/override/ide:
:(
thanks
-- PMM
Sam, can you investigate this?
Not seeing my T-b tags makes me grumble because I don't remember which I
reviewed and need to go check on the list.
If the error is a endianess bug related to fw_cfg, you can add the
"-trace fw_cfg*" in hd-geo-test::create_args() and rerun the tests on a
BE system, the bug should appear straightly on stdout.
Are FWLCHSEntry fields little-endian? Shouldn't
get_boot_devices_lchs_list() use some le32_to_cpu() call for the LCHS
values?
