Patchew URL: https://patchew.org/QEMU/20191017131615.19660-1-alex.ben...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH for 4.2 v6 00/54] Support for TCG plugins Type: series Message-id: 20191017131615.19660-1-alex.ben...@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' d836eae scripts/checkpatch.pl: don't complain about (foo, /* empty */) 6a6189b .travis.yml: add --enable-plugins tests b648611 include/exec: wrap cpu_ldst.h in CONFIG_TCG 52b9c19 accel/stubs: reduce headers from tcg-stub 4d74b4e tests/plugin: add hotpages to analyse memory access patterns 8ef1ff4 tests/plugin: add instruction execution breakdown abb472d tests/plugin: add a hotblocks plugin 20457aa tests/tcg: enable plugin testing 7b1a7a4 tests/tcg: drop test-i386-fprem from TESTS when not SLOW 4cb0cf5 tests/tcg: move "virtual" tests to EXTRA_TESTS 81c8812 tests/tcg: set QEMU_OPTS for all cris runs 0a8a37a tests/tcg/Makefile.target: fix path to config-host.mak 18cb7f9 tests/plugin: add sample plugins bc1a966 linux-user: support -plugin option 089f2f2 vl: support -plugin option bf99ebb plugin: add qemu_plugin_outs helper ee2763a plugin: add qemu_plugin_insn_disas helper 9f3330f plugin: expand the plugin_init function to include an info block f0f4fc1 plugin: add API symbols to qemu-plugins.symbols 1ec6198 configure: add --enable-plugins 1e03ebf translator: inject instrumentation from plugins 82417cf target/openrisc: fetch code with translator_ld 00499c8 target/xtensa: fetch code with translator_ld f876786 target/sparc: fetch code with translator_ld a85500f target/riscv: fetch code with translator_ld ff9b482 target/alpha: fetch code with translator_ld cd5e198 target/m68k: fetch code with translator_ld 0dd9382 target/hppa: fetch code with translator_ld abddb18 target/i386: fetch code with translator_ld cf525e9 target/sh4: fetch code with translator_ld 21f7317 target/ppc: fetch code with translator_ld e57f15c target/arm: fetch code with translator_ld 7268524 translator: add translator_ld{ub,sw,uw,l,q} bb715ab plugin-gen: add plugin_insn_append a99cb36 cpu: hook plugin vcpu events 87f6ee8 *-user: plugin syscalls d1149f5 *-user: notify plugin of exit d04ce7b translate-all: notify plugin code of tb_flush 80caa08 plugins: implement helpers for resolving hwaddr 9639665 tcg: let plugins instrument virtual memory accesses 3a440fd atomic_template: add inline trace/plugin helpers 3075615 plugin-gen: add module for TCG-related code d12bc8c tcg: add tcg_gen_st_ptr 0acadc3 cputlb: introduce get_page_addr_code_hostp a1d7d7f cputlb: document get_page_addr_code ae7c047 queue: add QTAILQ_REMOVE_SEVERAL d7b743f plugin: add implementation of the api fdcaec1 plugin: add core code 9aa3f8b plugin: add user-facing API 274e91a docs/devel: add plugins.rst design document dcbc372 translate-all: use cpu_in_exclusive_work_context() in tb_flush 9ef9697 cpu: introduce cpu_in_exclusive_context() 5f2168d trace: add mmu_index to mem_info ec66990 trace: expand mem_info:size_shift to 4 bits === OUTPUT BEGIN === 1/54 Checking commit ec6699058f0d (trace: expand mem_info:size_shift to 4 bits) 2/54 Checking commit 5f2168d69198 (trace: add mmu_index to mem_info) 3/54 Checking commit 9ef9697395c6 (cpu: introduce cpu_in_exclusive_context()) 4/54 Checking commit dcbc37211913 (translate-all: use cpu_in_exclusive_work_context() in tb_flush) 5/54 Checking commit 274e91ac8058 (docs/devel: add plugins.rst design document) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #24: new file mode 100644 total: 0 errors, 1 warnings, 116 lines checked Patch 5/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/54 Checking commit 9aa3f8bc190f (plugin: add user-facing API) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 WARNING: architecture specific defines should be avoided #41: FILE: include/qemu/qemu-plugin.h:22: +#if defined _WIN32 || defined __CYGWIN__ WARNING: architecture specific defines should be avoided #49: FILE: include/qemu/qemu-plugin.h:30: + #if __GNUC__ >= 4 total: 0 errors, 3 warnings, 351 lines checked Patch 6/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/54 Checking commit fdcaec175fc9 (plugin: add core code) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #99: new file mode 100644 ERROR: externs should be avoided in .c files #947: FILE: plugins/loader.c:63: +extern struct qemu_plugin_state plugin; total: 1 errors, 1 warnings, 1284 lines checked Patch 7/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/54 Checking commit d7b743fa06bc (plugin: add implementation of the api) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 ERROR: "foo * bar" should be "foo *bar" #295: FILE: plugins/api.c:255: +static MachineState * get_ms(void) total: 1 errors, 1 warnings, 290 lines checked Patch 8/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/54 Checking commit ae7c047d61b8 (queue: add QTAILQ_REMOVE_SEVERAL) WARNING: Block comments use a leading /* on a separate line #32: FILE: include/qemu/queue.h:431: + } while (/*CONSTCOND*/0) total: 0 errors, 1 warnings, 16 lines checked Patch 9/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/54 Checking commit a1d7d7f7a0e1 (cputlb: document get_page_addr_code) 11/54 Checking commit 0acadc319972 (cputlb: introduce get_page_addr_code_hostp) 12/54 Checking commit d12bc8c3e2dd (tcg: add tcg_gen_st_ptr) 13/54 Checking commit 307561543fb6 (plugin-gen: add module for TCG-related code) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 1123 lines checked Patch 13/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/54 Checking commit 3a440fd23537 (atomic_template: add inline trace/plugin helpers) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 299 lines checked Patch 14/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/54 Checking commit 9639665cd1db (tcg: let plugins instrument virtual memory accesses) WARNING: line over 80 characters #111: FILE: include/exec/cpu_ldst_template.h:91: + uint16_t meminfo = trace_mem_build_info(SHIFT, false, MO_TE, false, mmu_idx); total: 0 errors, 1 warnings, 325 lines checked Patch 15/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/54 Checking commit 80caa08b83b6 (plugins: implement helpers for resolving hwaddr) ERROR: line over 90 characters #61: FILE: accel/tcg/cputlb.c:1279: + data->v.io.section = iotlb_to_section(cpu, iotlbentry->addr, iotlbentry->attrs); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 WARNING: line over 80 characters #137: FILE: include/qemu/qemu-plugin.h:294: +uint64_t qemu_plugin_hwaddr_device_offset(const struct qemu_plugin_hwaddr *haddr); WARNING: line over 80 characters #193: FILE: plugins/api.c:279: +uint64_t qemu_plugin_hwaddr_device_offset(const struct qemu_plugin_hwaddr *haddr) WARNING: line over 80 characters #198: FILE: plugins/api.c:284: + ram_addr_t ram_addr = qemu_ram_addr_from_host((void *) haddr->v.ram.hostaddr); WARNING: line over 80 characters #200: FILE: plugins/api.c:286: + error_report("Bad ram pointer %"PRIx64"", haddr->v.ram.hostaddr); total: 1 errors, 5 warnings, 174 lines checked Patch 16/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/54 Checking commit d04ce7b13bb6 (translate-all: notify plugin code of tb_flush) 18/54 Checking commit d1149f5a33f4 (*-user: notify plugin of exit) 19/54 Checking commit 87f6ee8a1d85 (*-user: plugin syscalls) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #93: new file mode 100644 total: 0 errors, 1 warnings, 127 lines checked Patch 19/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/54 Checking commit a99cb36d7222 (cpu: hook plugin vcpu events) 21/54 Checking commit bb715ab2fc98 (plugin-gen: add plugin_insn_append) 22/54 Checking commit 7268524a6762 (translator: add translator_ld{ub,sw,uw,l,q}) ERROR: space prohibited before that close parenthesis ')' #118: FILE: include/exec/translator.h:198: +GEN_TRANSLATOR_LD(translator_ldub, ldb, ldub, uint8_t, 0, /* no swap */ ) total: 1 errors, 0 warnings, 95 lines checked Patch 22/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/54 Checking commit e57f15caee2c (target/arm: fetch code with translator_ld) 24/54 Checking commit 21f731780d7b (target/ppc: fetch code with translator_ld) 25/54 Checking commit cf525e9be4d8 (target/sh4: fetch code with translator_ld) 26/54 Checking commit abddb18720b0 (target/i386: fetch code with translator_ld) 27/54 Checking commit 0dd938267652 (target/hppa: fetch code with translator_ld) 28/54 Checking commit cd5e198a31a3 (target/m68k: fetch code with translator_ld) 29/54 Checking commit ff9b48215642 (target/alpha: fetch code with translator_ld) 30/54 Checking commit a85500f99f2d (target/riscv: fetch code with translator_ld) 31/54 Checking commit f876786c16ea (target/sparc: fetch code with translator_ld) 32/54 Checking commit 00499c8b0294 (target/xtensa: fetch code with translator_ld) 33/54 Checking commit 82417cf6c045 (target/openrisc: fetch code with translator_ld) 34/54 Checking commit 1e03ebf398a6 (translator: inject instrumentation from plugins) 35/54 Checking commit 1ec6198f7f3e (configure: add --enable-plugins) 36/54 Checking commit f0f4fc1fdc51 (plugin: add API symbols to qemu-plugins.symbols) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #136: new file mode 100644 total: 0 errors, 1 warnings, 166 lines checked Patch 36/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 37/54 Checking commit 9f3330fdf451 (plugin: expand the plugin_init function to include an info block) ERROR: line over 90 characters #84: FILE: plugins/loader.c:65: +typedef int (*qemu_plugin_install_func_t)(qemu_plugin_id_t, const qemu_info_t *, int, char **); total: 1 errors, 0 warnings, 100 lines checked Patch 37/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 38/54 Checking commit ee2763ab0cda (plugin: add qemu_plugin_insn_disas helper) 39/54 Checking commit bf99ebbeef7d (plugin: add qemu_plugin_outs helper) 40/54 Checking commit 089f2f2dd71d (vl: support -plugin option) 41/54 Checking commit bc1a966d26f6 (linux-user: support -plugin option) 42/54 Checking commit 18cb7f912d0d (tests/plugin: add sample plugins) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644 total: 0 errors, 1 warnings, 287 lines checked Patch 42/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 43/54 Checking commit 0a8a37a897c6 (tests/tcg/Makefile.target: fix path to config-host.mak) 44/54 Checking commit 81c8812c0f34 (tests/tcg: set QEMU_OPTS for all cris runs) 45/54 Checking commit 4cb0cf55517d (tests/tcg: move "virtual" tests to EXTRA_TESTS) 46/54 Checking commit 7b1a7a48e5b5 (tests/tcg: drop test-i386-fprem from TESTS when not SLOW) 47/54 Checking commit 20457aac4f30 (tests/tcg: enable plugin testing) 48/54 Checking commit abb472dc5c7d (tests/plugin: add a hotblocks plugin) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #33: new file mode 100644 WARNING: line over 80 characters #101: FILE: tests/plugin/hotblocks.c:64: + g_string_append_printf(report, "%#016"PRIx64", %d, %ld, %"PRId64"\n", total: 0 errors, 2 warnings, 150 lines checked Patch 48/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 49/54 Checking commit 8ef1ff47fded (tests/plugin: add instruction execution breakdown) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644 ERROR: space required after that ',' (ctx:VxV) #100: FILE: tests/plugin/howvec.c:69: + { " Add/Sub (imm,tags)","asit", 0x1f800000, 0x11800000, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #123: FILE: tests/plugin/howvec.c:92: + { " AdvSimd ldstmult++","advlsmp",0xbfb00000, 0x0c800000, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #123: FILE: tests/plugin/howvec.c:92: + { " AdvSimd ldstmult++","advlsmp",0xbfb00000, 0x0c800000, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #125: FILE: tests/plugin/howvec.c:94: + { " AdvSimd ldst++", "advlssp",0xbf800000, 0x0d800000, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #129: FILE: tests/plugin/howvec.c:98: + { " ldst noalloc pair", "ldstnap",0x3b800000, 0x28000000, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #133: FILE: tests/plugin/howvec.c:102: + { " ldst reg (reg off)","ldstro", 0x3b200b00, 0x38200800, COUNT_CLASS}, ^ WARNING: line over 80 characters #154: FILE: tests/plugin/howvec.c:123: + { "Unclassified", "unclas", 0x00000000, 0x00000000, COUNT_INDIVIDUAL}, WARNING: line over 80 characters #163: FILE: tests/plugin/howvec.c:132: + { "Unclassified", "unclas", 0x00000000, 0x00000000, COUNT_INDIVIDUAL}, WARNING: line over 80 characters #168: FILE: tests/plugin/howvec.c:137: + { "Unclassified", "unclas", 0x00000000, 0x00000000, COUNT_INDIVIDUAL}, ERROR: that open brace { should be on the previous line #178: FILE: tests/plugin/howvec.c:147: +static ClassSelector class_tables[] = +{ WARNING: line over 80 characters #213: FILE: tests/plugin/howvec.c:182: + g_string_append_printf(report, "Class: %-24s\tcounted individually\n", ERROR: space required after that ',' (ctx:VxV) #229: FILE: tests/plugin/howvec.c:198: + g_string_append_printf(report,"Individual Instructions:\n"); ^ WARNING: line over 80 characters #235: FILE: tests/plugin/howvec.c:204: + g_string_append_printf(report, "Instr: %-24s\t(%ld hits)\t(op=%#08x/%s)\n", ERROR: "foo * bar" should be "foo *bar" #259: FILE: tests/plugin/howvec.c:228: +static uint64_t * find_counter(struct qemu_plugin_insn *insn) WARNING: line over 80 characters #295: FILE: tests/plugin/howvec.c:264: + GUINT_TO_POINTER(opcode)); total: 9 errors, 7 warnings, 359 lines checked Patch 49/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 50/54 Checking commit 4d74b4e6c3af (tests/plugin: add hotpages to analyse memory access patterns) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644 WARNING: line over 80 characters #107: FILE: tests/plugin/hotpages.c:76: + g_autoptr(GString) report = g_string_new("Addr, RCPUs, Reads, WCPUs, Writes\n"); total: 0 errors, 2 warnings, 198 lines checked Patch 50/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 51/54 Checking commit 52b9c194674d (accel/stubs: reduce headers from tcg-stub) 52/54 Checking commit b64861116da7 (include/exec: wrap cpu_ldst.h in CONFIG_TCG) 53/54 Checking commit 6a6189babbbe (.travis.yml: add --enable-plugins tests) 54/54 Checking commit d836eaec1f37 (scripts/checkpatch.pl: don't complain about (foo, /* empty */)) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20191017131615.19660-1-alex.ben...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com