On 23.10.19 17:49, Richard Henderson wrote:
Using uintptr_t instead of target_ulong meant that, for 64-bit guest and 32-bit host, we truncated the guest address comparator and so may not hit the tlb when we should.Fixes: 4811e9095c0 Signed-off-by: Richard Henderson <richard.hender...@linaro.org> --- Fixes aarch64 emulation on arm32 host, after our recent changes to tlb probing. r~ --- accel/tcg/cputlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 6f4194df96..5eebddcca8 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -1189,7 +1189,7 @@ void *tlb_vaddr_to_host(CPUArchState *env, abi_ptr addr, MMUAccessType access_type, int mmu_idx) { CPUTLBEntry *entry = tlb_entry(env, mmu_idx, addr); - uintptr_t tlb_addr, page; + target_ulong tlb_addr, page; size_t elt_ofs;switch (access_type) {
probe_access() seems to be fine Reviewed-by: David Hildenbrand <da...@redhat.com> -- Thanks, David / dhildenb
