Paolo Bonzini <pbonz...@redhat.com> writes: > Please take a look at include/qemu/fifo8.h instead of rolling your own > ring buffer. Note that it is not thread-safe so you'll have to keep > that part.
Sorry for not looking around sooner, and thanks for the pointer. I've also cleaned up the other issues. > Kudos for the unlock/lock_iothread; I am not really familiar with the > semihosting code and I would have naively assumed that it runs without > that lock taken. I discovered by testing that the semihosting functions were entered with the lock taken :-) I'll post an updated version of this patch to the list shortly. Thanks again for your review; I really appreciate the time you've taken to look at my patch. -- -keith
signature.asc
Description: PGP signature
