> > +    aio_set_fd_handler(ctx, fd, false, (IOHandler *)qemu_coroutine_enter,
> > +                       NULL, NULL, qemu_coroutine_self());
> 
> This cast is unsafe.  If qemu_coroutine_enter()'s prototype is changed
> there will be no compiler warning that the prototypes are now
> incompatible.
> 
> Please keep fd_coroutine_enter() so the code is type-safe.

OK. Sent v4 with suggested changes.


Reply via email to