Le 25/10/2019 à 16:01, Paolo Bonzini a écrit : > On 22/10/19 13:17, Laurent Vivier wrote: >> + if (s->dma_memory_read) { >> + s->dma_memory_read(s->dma_opaque, &s->cmdbuf[s->cmdlen], len); >> + } else { >> + set_pdma(s, CMD, s->cmdlen, len); >> + s->pdma_cb = do_dma_pdma_cb; >> + esp_raise_drq(s); >> + return; >> + } >> + trace_esp_handle_ti_cmd(s->cmdlen); >> + s->ti_size = 0; >> + s->cmdlen = 0; >> + s->do_cmd = 0; >> + do_cmd(s, s->cmdbuf); >> return; > > Can you explain these lines after s->dma_memory_read? I suppose they > are related to > >> - } >> - if (s->do_cmd) { >> + } else if (s->do_cmd) { > > If so, it would be nice to make those a separate patch. Otherwise seems > okay.
Sent a new series with separate patches for ESP. Could you have a look? Thanks, Laurent