On Thu, 7 Nov 2019 at 17:09, Palmer Dabbelt <pal...@dabbelt.com> wrote: > > On Wed, 06 Nov 2019 16:47:20 PST (-0800), Alistair Francis wrote: > > Coreboot developers have requested that they have at least 32MB of flash > > to load binaries. We currently have 32MB of flash, but it is split in > > two to allow loading two flash binaries. Let's increase the flash size > > from 32MB to 64MB to ensure we have a single region that is 32MB. > > > > No QEMU release has include flash in the RISC-V virt machine, so this > > isn't a breaking change. > > Even if we had, I wouldn't consider it a breaking change because it adds to > the memory map so existing programs will continue to run fine.
I have a feeling you may find that some old command lines won't work any more because they specified a flash contents binary that was the old 32MB and now it needs to be padded out to 64MB. But I haven't tested whether this theory is correct (it will depend on how the flash contents are specified -- --bios will be ok, as will loading contents directly as an ELF file or similar, specifying contents by a -drive option intended to be consumed by the pflash is the case which likely needs extra padding.) thanks -- PMM
