On 07.11.19 22:10, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20191107163708.833192-1-mre...@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [PATCH v3 00/22] iotests: Allow ./check -o data_file > Type: series > Message-id: 20191107163708.833192-1-mre...@redhat.com > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > ./scripts/checkpatch.pl --mailback base.. > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Switched to a new branch 'test' > 01a2839 iotests: Allow check -o data_file > 31bc07b iotests: Disable data_file where it cannot be used > 98a2575 iotests: Make 198 work with data_file > e8f406f iotests: Make 137 work with data_file > 46cc09d iotests: Make 110 work with data_file > 1f7b2e5 iotests: Make 091 work with data_file > 401d3ef iotests: Avoid cp/mv of test images > a3746a2 iotests: Use _rm_test_img for deleting test images > 37a01c8 iotests: Avoid qemu-img create > a05c5ec iotests: Drop IMGOPTS use in 267 > 44aac70 iotests: Replace IMGOPTS='' by --no-opts > cb9ee70 iotests: Replace IMGOPTS= by -o > 3c2893f iotests: Inject space into -ocompat=0.10 in 051 > 8b5f9d4 iotests: Add -o and --no-opts to _make_test_img > 239f933 iotests: Let _make_test_img parse its parameters > 405ddde iotests: Drop compat=1.1 in 050 > 527ae22 iotests: Replace IMGOPTS by _unsupported_imgopts > 77f688d iotests: Filter refcount_order in 036 > 3f29d5f iotests: Add _filter_json_filename > 58975a8 iotests/qcow2.py: Split feature fields into bits > 7ea641e iotests/qcow2.py: Add dump-header-exts > 469af5e iotests: s/qocw2/qcow2/ > > === OUTPUT BEGIN === > 1/22 Checking commit 469af5ede216 (iotests: s/qocw2/qcow2/) > 2/22 Checking commit 7ea641ec6b0a (iotests/qcow2.py: Add dump-header-exts) > ERROR: line over 90 characters > #33: FILE: tests/qemu-iotests/qcow2.py:237: > + [ 'dump-header-exts', cmd_dump_header_exts, 0, 'Dump image > header extensions' ],
As in v1, I deliberately followed the existing style in this file and believe it’s for the best. Max
signature.asc
Description: OpenPGP digital signature
