Patchew URL: https://patchew.org/QEMU/cover.1573477032.git.jan.kis...@siemens.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [RFC][PATCH 0/3] IVSHMEM version 2 device for QEMU Type: series Message-id: cover.1573477032.git.jan.kis...@siemens.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 45625de contrib: Add server for ivshmem revision 2 df18ce0 docs/specs: Add specification of ivshmem device revision 2 ff35318 hw/misc: Add implementation of ivshmem revision 2 device === OUTPUT BEGIN === 1/3 Checking commit ff35318fdf84 (hw/misc: Add implementation of ivshmem revision 2 device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #63: new file mode 100644 ERROR: return is not a function, parentheses are not required #206: FILE: hw/misc/ivshmem2.c:139: + return (ivs->features & (1 << feature)); ERROR: memory barrier without comment #250: FILE: hw/misc/ivshmem2.c:183: + smp_mb(); ERROR: braces {} are necessary for all arms of this statement #625: FILE: hw/misc/ivshmem2.c:558: + if (msg->vector == 0) [...] WARNING: Block comments use a leading /* on a separate line #775: FILE: hw/misc/ivshmem2.c:708: +/* Select the MSI-X vectors used by device. WARNING: Block comments use a trailing */ on a separate line #777: FILE: hw/misc/ivshmem2.c:710: + * we just enable all vectors on init and after reset. */ total: 3 errors, 3 warnings, 1147 lines checked Patch 1/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/3 Checking commit df18ce079161 (docs/specs: Add specification of ivshmem device revision 2) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #24: new file mode 100644 total: 0 errors, 1 warnings, 333 lines checked Patch 2/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/3 Checking commit 45625def0d51 (contrib: Add server for ivshmem revision 2) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #77: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #174: FILE: contrib/ivshmem2-server/ivshmem2-server.c:86: +/* free a peer when the server advertises a disconnection or when the WARNING: Block comments use a trailing */ on a separate line #175: FILE: contrib/ivshmem2-server/ivshmem2-server.c:87: + * server is freed */ ERROR: memory barrier without comment #194: FILE: contrib/ivshmem2-server/ivshmem2-server.c:106: + smp_mb(); WARNING: Block comments use a leading /* on a separate line #276: FILE: contrib/ivshmem2-server/ivshmem2-server.c:188: + /* XXX: this could use id allocation such as Linux IDA, or simply WARNING: Block comments use a trailing */ on a separate line #277: FILE: contrib/ivshmem2-server/ivshmem2-server.c:189: + * a free-list */ WARNING: Block comments use a leading /* on a separate line #342: FILE: contrib/ivshmem2-server/ivshmem2-server.c:254: +/* Try to ftruncate a file to next power of 2 of shmsize. WARNING: Block comments use a trailing */ on a separate line #346: FILE: contrib/ivshmem2-server/ivshmem2-server.c:258: + * shm_size value. */ WARNING: Block comments use a leading /* on a separate line #619: FILE: contrib/ivshmem2-server/ivshmem2-server.h:63: + const char *shm_path; /**< Path to the shared memory; path WARNING: Block comments use * on subsequent lines #620: FILE: contrib/ivshmem2-server/ivshmem2-server.h:64: + const char *shm_path; /**< Path to the shared memory; path + corresponds to a POSIX shm name or a WARNING: Block comments use a trailing */ on a separate line #621: FILE: contrib/ivshmem2-server/ivshmem2-server.h:65: + hugetlbfs mount point. */ WARNING: Block comments use a leading /* on a separate line #622: FILE: contrib/ivshmem2-server/ivshmem2-server.h:66: + bool use_shm_open; /**< true to use shm_open, false for WARNING: Block comments use * on subsequent lines #623: FILE: contrib/ivshmem2-server/ivshmem2-server.h:67: + bool use_shm_open; /**< true to use shm_open, false for + file-backed shared memory */ WARNING: Block comments use a trailing */ on a separate line #623: FILE: contrib/ivshmem2-server/ivshmem2-server.h:67: + file-backed shared memory */ ERROR: spaces required around that '*' (ctx:VxV) #742: FILE: contrib/ivshmem2-server/main.c:22: +#define IVSHMEM_SERVER_DEFAULT_SHM_SIZE (4*1024*1024) ^ ERROR: spaces required around that '*' (ctx:VxV) #742: FILE: contrib/ivshmem2-server/main.c:22: +#define IVSHMEM_SERVER_DEFAULT_SHM_SIZE (4*1024*1024) ^ WARNING: Block comments use a leading /* on a separate line #906: FILE: contrib/ivshmem2-server/main.c:186: +/* wait for events on listening server unix socket and connected client WARNING: Block comments use a trailing */ on a separate line #907: FILE: contrib/ivshmem2-server/main.c:187: + * sockets */ WARNING: Block comments use a leading /* on a separate line #977: FILE: contrib/ivshmem2-server/main.c:257: + /* Ignore SIGPIPE, see this link for more info: WARNING: Block comments use a trailing */ on a separate line #978: FILE: contrib/ivshmem2-server/main.c:258: + * http://www.mail-archive.com/libevent-users@monkey.org/msg01606.html */ total: 3 errors, 17 warnings, 963 lines checked Patch 3/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/cover.1573477032.git.jan.kis...@siemens.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com