On Wed, Nov 13, 2019 at 05:35:59PM +0100, Philippe Mathieu-Daudé wrote: > On 11/12/19 8:47 PM, Eduardo Habkost wrote: > > On Tue, Nov 12, 2019 at 06:42:00PM +0000, Sunil Muthuswamy wrote: > > > > > > > > > > -----Original Message----- > > > > From: Sunil Muthuswamy > > > > Sent: Friday, November 8, 2019 12:32 PM > > > > To: 'Paolo Bonzini' <pbonz...@redhat.com>; 'Richard Henderson' > > > > <r...@twiddle.net>; 'Eduardo Habkost' <ehabk...@redhat.com>; 'Stefan > > > > Weil' <s...@weilnetz.de> > > > > Cc: 'qemu-devel@nongnu.org' <qemu-devel@nongnu.org>; Justin Terry (VM) > > > > <jute...@microsoft.com> > > > > Subject: [PATCH] WHPX: refactor load library > > > > > > > > This refactors the load library of WHV libraries to make it more > > > > modular. It makes a helper routine that can be called on demand. > > > > This allows future expansion of load library/functions to support > > > > functionality that is depenedent on some feature being available. > > > > > > > > Signed-off-by: Sunil Muthuswamy <sunil...@microsoft.com> > > > > --- > > > > > > Can I possibly get some eyes on this? > > > > I'd be glad to queue the patch if we get a Reviewed-by line from > > somebody who understands Windows and WHPX. Maybe Justin? > > Can we wait for approval from the Microsoft legal department first? > So we can start testing WHPX builds, and reduce the possibilities to > introduce regressions. > > Testing is ready, we are waiting for Microsoft to merge, see: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg646351.html
Making it easier for other people to test WHPX would be nice. But in case this is not sorted out soon, I don't see a reason to not merge WHPX changes if they are reviewed and approved by the main author of that code (Justin). -- Eduardo
