Re: [PATCH] linux-user: fix translation of statx structures

[Philippe Mathieu-Daudé]

On 11/22/19 7:27 PM, Aleksandar Markovic wrote:

On Fri, Nov 22, 2019 at 7:22 PM Ariadne Conill <aria...@dereferenced.org> wrote:

All timestamps were copied to atime instead of to their respective
fields.

Fixes: efa921845c0

Signed-off-by: Ariadne Conill <aria...@dereferenced.org>
---

What a bug.

Laurent, perhaps a good candidate for 4.2?

Agreed.

Thanks for submitting this, Ariadne Conill!

And welcome to QEMU :)

Reviewed-by: Aleksandar Markovic <amarko...@wavecomp.com>

Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>

  linux-user/syscall.c | 12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index ce399a55f0..171c0caef3 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -6743,12 +6743,12 @@ static inline abi_long host_to_target_statx(struct 
target_statx *host_stx,
      __put_user(host_stx->stx_attributes_mask, 
&target_stx->stx_attributes_mask);
      __put_user(host_stx->stx_atime.tv_sec, &target_stx->stx_atime.tv_sec);
      __put_user(host_stx->stx_atime.tv_nsec, &target_stx->stx_atime.tv_nsec);
-    __put_user(host_stx->stx_btime.tv_sec, &target_stx->stx_atime.tv_sec);
-    __put_user(host_stx->stx_btime.tv_nsec, &target_stx->stx_atime.tv_nsec);
-    __put_user(host_stx->stx_ctime.tv_sec, &target_stx->stx_atime.tv_sec);
-    __put_user(host_stx->stx_ctime.tv_nsec, &target_stx->stx_atime.tv_nsec);
-    __put_user(host_stx->stx_mtime.tv_sec, &target_stx->stx_atime.tv_sec);
-    __put_user(host_stx->stx_mtime.tv_nsec, &target_stx->stx_atime.tv_nsec);
+    __put_user(host_stx->stx_btime.tv_sec, &target_stx->stx_btime.tv_sec);
+    __put_user(host_stx->stx_btime.tv_nsec, &target_stx->stx_btime.tv_nsec);
+    __put_user(host_stx->stx_ctime.tv_sec, &target_stx->stx_ctime.tv_sec);
+    __put_user(host_stx->stx_ctime.tv_nsec, &target_stx->stx_ctime.tv_nsec);
+    __put_user(host_stx->stx_mtime.tv_sec, &target_stx->stx_mtime.tv_sec);
+    __put_user(host_stx->stx_mtime.tv_nsec, &target_stx->stx_mtime.tv_nsec);
      __put_user(host_stx->stx_rdev_major, &target_stx->stx_rdev_major);
      __put_user(host_stx->stx_rdev_minor, &target_stx->stx_rdev_minor);
      __put_user(host_stx->stx_dev_major, &target_stx->stx_dev_major);
--
2.24.0