Hi, Here are a few more "unused-but-set-variable" warning fixes which I got when rebuilding qemu. I can fold the other 2 patches that were already sent to this list in this series if needed.
The 3rd hunk of the ehci patch needs a review from someone who knows the code, different values are assigned to the "pid" variable which the patch deletes, and further down in the function, ehci->pid is used, so maybe an "ehci->pid = pid;" line is missing in this function, in which case the patch would hide a bug instead of solving it. Similarly, the variable removed from the linux-user patch is assigned different values depending on some conditions, maybe it's not right to remove it but it should be used for "something". Christophe Christophe Fergeau (3): lsi: Fix unused-but-set-variable warning ehci: Fix unused-but-set-variable warning linux-user: Fix unused-but-set-variable warning hw/lsi53c895a.c | 2 -- hw/usb-ehci.c | 11 +---------- linux-user/linuxload.c | 9 +-------- 3 files changed, 2 insertions(+), 20 deletions(-) -- 1.7.5.2
