On 10/10/19 10:54 PM, Eduardo Habkost wrote:
> On Fri, Sep 06, 2019 at 07:11:57PM +0000, Moger, Babu wrote:
>> This is an effort to re-arrange few data structure for better
>> readability. Add X86CPUTopoInfo which will have all the topology
>> informations required to build the cpu topology. There is no
>> functional changes.
>>
>> Signed-off-by: Babu Moger <babu.mo...@amd.com>
>> ---
> [...]
>> +typedef struct X86CPUTopoInfo {
>> + unsigned numa_nodes;
>> + unsigned nr_sockets;
>> + unsigned nr_dies;
>> + unsigned nr_cores;
>> + unsigned nr_threads;
>> +} X86CPUTopoInfo;
>
> With more complex topologies, the meaning of each of those fields
> may be ambiguous. e.g.: is nr_cores cores per die, cores per
> ccx, or cores per socket? Maybe we should use this opportunity
> to use more explicit names like threads_per_core, cores_per_die,
> dies_per_socket.
Yes. Changed it to
typedef struct X86CPUTopoInfo {
unsigned nodes_per_pkg;
unsigned dies_per_pkg;
unsigned cores_per_die;
unsigned threads_per_core;
} X86CPUTopoInfo;
