On 06/02/2011 02:03 PM, Anthony Liguori wrote:
>>>>>>>> { "event": "BLOCK_IO_ERROR",
>>>>>>>> "data": { "device": "ide0-hd1",
>>>>>>>> "operation": "write",
>>>>>>>> "action": "stop",
>>>>>>>> "reason": "enospc", }
>>>>>>>
>>>>>> I'm ok with either way. But in case you meant the second one, I guess
>>>>>> we should make "reason" a dictionary so that we can group related
>>>>>> information when we extend the field, for example:
>>>>>>
>>>>>> "reason": { "no space": false, "no permission": true }
The idea for an event with details certainly has merit.
>>>>>
>>>>> Why would we ever have "no permission"?
SELinux denial, perhaps?
>
>> Maybe libvirt guys could provide more input wrt the error reason usage.
>> If we don't have valid use cases for other errors, then I'll agree that
>> providing only "no space" is enough.
>
> Definitely! Adding libvirt to the CC to help encourage their input.
We could always start with just one reason "no space", and add more
later if and when we come up for use cases.
--
Eric Blake ebl...@redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
