On 09/12/19 16:31, Philippe Mathieu-Daudé wrote: > On 12/9/19 4:01 PM, Paolo Bonzini wrote: >> /** >> + * object_new_with_class: >> + * @klass: The class to instantiate. >> + * >> + * This function will initialize a new object using heap allocated >> memory. >> + * The returned object has a reference count of 1, and will be freed >> when >> + * the last reference is dropped. >> + * >> + * Returns: The newly allocated and instantiated object. >> + */ >> +Object *object_new_with_class(ObjectClass *klass); > > The function name bugs me... Pick your poison? > > object_new_by_class > object_new_of_class > object_new_for_class > object_new_from_class > object_new_with_class > > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
>From and with both make sense, I just picked the one consistent with object_new_with_type. Paolo
