Patchew URL: https://patchew.org/QEMU/1575903705-12925-1-git-send-email-pbonz...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v2 00/18] Complete the implementation of -accel Type: series Message-id: 1575903705-12925-1-git-send-email-pbonz...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' fabb8b3 kvm: convert "-machine kernel_irqchip" to an accelerator property 6a1dbee kvm: introduce kvm_kernel_irqchip_* functions 800c958 kvm: convert "-machine kvm_shadow_mem" to an accelerator property d72d3ea xen: convert "-machine igd-passthru" to an accelerator property 24067b2 tcg: add "-accel tcg, tb-size" and deprecate "-tb-size" 8b42a7e tcg: convert "-accel threads" to a QOM property 3ebd51d accel: pass object to accel_init_machine 4351594 qom: add object_new_with_class 314fb80 qom: introduce object_register_sugar_prop 0995654 vl: warn for unavailable accelerators, clarify messages 5c7b904 vl: configure accelerators from -accel options 6a4da93 vl: introduce object_parse_property_opt a4b9880 accel: compile accel/accel.c just once 62cdc79 vl: merge -accel processing into configure_accelerators 6246357 vl: extract accelerator option processing to a separate function 63877b9 tcg: move qemu_tcg_configure to accel/tcg/tcg-all.c 1bd01e6 vl: move icount configuration earlier 86d414d memory: do not look at current_machine->accel === OUTPUT BEGIN === 1/18 Checking commit 86d414d86513 (memory: do not look at current_machine->accel) 2/18 Checking commit 1bd01e62ccaf (vl: move icount configuration earlier) 3/18 Checking commit 63877b94ad15 (tcg: move qemu_tcg_configure to accel/tcg/tcg-all.c) 4/18 Checking commit 62463579c28f (vl: extract accelerator option processing to a separate function) 5/18 Checking commit 62cdc7986f89 (vl: merge -accel processing into configure_accelerators) 6/18 Checking commit a4b98800e6a2 (accel: compile accel/accel.c just once) 7/18 Checking commit 6a4da93b15b0 (vl: introduce object_parse_property_opt) 8/18 Checking commit 5c7b904bf344 (vl: configure accelerators from -accel options) WARNING: line over 80 characters #206: FILE: vl.c:2909: + error_report("The -accel and \"-machine accel=\" options are incompatible"); WARNING: line over 80 characters #214: FILE: vl.c:2915: + do_configure_accelerator, &init_failed, &error_fatal)) { total: 0 errors, 2 warnings, 196 lines checked Patch 8/18 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/18 Checking commit 099565450487 (vl: warn for unavailable accelerators, clarify messages) 10/18 Checking commit 314fb80d9a2c (qom: introduce object_register_sugar_prop) WARNING: line over 80 characters #24: FILE: include/qom/object.h:682: +void object_register_sugar_prop(const char *driver, const char *prop, const char *value); WARNING: line over 80 characters #48: FILE: qom/object.c:428: +void object_register_sugar_prop(const char *driver, const char *prop, const char *value) total: 0 errors, 2 warnings, 61 lines checked Patch 10/18 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/18 Checking commit 4351594192c0 (qom: add object_new_with_class) WARNING: line over 80 characters #142: FILE: vl.c:3992: + current_machine = MACHINE(object_new_with_class(OBJECT_CLASS(machine_class))); total: 0 errors, 1 warnings, 96 lines checked Patch 11/18 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/18 Checking commit 3ebd51dc3893 (accel: pass object to accel_init_machine) 13/18 Checking commit 8b42a7e25f3f (tcg: convert "-accel threads" to a QOM property) 14/18 Checking commit 24067b2d77d6 (tcg: add "-accel tcg, tb-size" and deprecate "-tb-size") ERROR: line over 90 characters #189: FILE: vl.c:3750: + warn_report("The -tb-size option is deprecated, use -accel tcg,tb-size instead"); WARNING: line over 80 characters #190: FILE: vl.c:3751: + object_register_sugar_prop(ACCEL_CLASS_NAME("tcg"), "tb-size", optarg); total: 1 errors, 1 warnings, 148 lines checked Patch 14/18 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/18 Checking commit d72d3ea5e7e4 (xen: convert "-machine igd-passthru" to an accelerator property) 16/18 Checking commit 800c95819ba7 (kvm: convert "-machine kvm_shadow_mem" to an accelerator property) WARNING: line over 80 characters #228: FILE: target/i386/kvm.c:2166: + shadow_mem = object_property_get_int(OBJECT(s), "kvm-shadow-mem", &error_abort); total: 0 errors, 1 warnings, 197 lines checked Patch 16/18 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/18 Checking commit 6a1dbee7f610 (kvm: introduce kvm_kernel_irqchip_* functions) 18/18 Checking commit fabb8b30a711 (kvm: convert "-machine kernel_irqchip" to an accelerator property) WARNING: Block comments use a leading /* on a separate line #85: FILE: accel/kvm/kvm-all.c:3007: + /* The value was checked in visit_type_OnOffSplit() above. If total: 0 errors, 1 warnings, 241 lines checked Patch 18/18 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1575903705-12925-1-git-send-email-pbonz...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com