Am 05.12.2019 um 14:46 hat Stefan Hajnoczi geschrieben: > Only apply --image-opts to the topmost image when listing an entire > backing chain. It is incorrect to treat backing filenames as image > options. Assuming we have the backing chain t.IMGFMT.base <- > t.IMGFMT.mid <- t.IMGFMT, qemu-img info fails as follows: > > $ qemu-img info --backing-chain --image-opts \ > driver=qcow2,file.driver=file,file.filename=t.IMGFMT > qemu-img: Could not open 'TEST_DIR/t.IMGFMT.mid': Cannot find > device=TEST_DIR/t.IMGFMT.mid nor node_name=TEST_DIR/t.IMGFMT.mid > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
> diff --git a/tests/qemu-iotests/279 b/tests/qemu-iotests/279 > new file mode 100755 > index 0000000000..b555a92859 > --- /dev/null > +++ b/tests/qemu-iotests/279 > @@ -0,0 +1,56 @@ > +#!/usr/bin/env bash > +# > +# Test qemu-img --backing-chain --image-opts > +# > +# Copyright (C) 2019 Red Hat, Inc. > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 2 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see <http://www.gnu.org/licenses/>. > +# > + > +seq=$(basename "$0") > +echo "QA output created by $seq" > + > +status=1 # failure is the default! > + > +_cleanup() > +{ > + _cleanup_test_img I'm squashing in this fixup: diff --git a/tests/qemu-iotests/279 b/tests/qemu-iotests/279 index b555a92859..6682376808 100755 --- a/tests/qemu-iotests/279 +++ b/tests/qemu-iotests/279 @@ -26,6 +26,7 @@ status=1 # failure is the default! _cleanup() { _cleanup_test_img + rm -f "$TEST_IMG.mid" } trap "_cleanup; exit \$status" 0 1 2 3 15 Thanks, applied to the block branch. Kevin
