On Thu, 2 Jun 2011 13:57:50 +0200 Alexander Graf <ag...@suse.de> wrote:
> diff --git a/pc-bios/mpc8544ds.dts b/pc-bios/mpc8544ds.dts > index 872152d..9b95bfd 100644 > --- a/pc-bios/mpc8544ds.dts > +++ b/pc-bios/mpc8544ds.dts > @@ -82,6 +82,12 @@ > compatible = "chrp,open-pic"; > device_type = "open-pic"; > }; > + > + global-utilities@e0000 { //global utilities block > + compatible = "fsl,mpc8548-guts"; > + reg = <0xe0000 0x1000>; > + fsl,has-rstcr; > + }; > }; We're not providing a full mpc8548 (or mpc8544) guts, only the rstcr register. Currently Linux looks for a node with the name "global-utilities" and a property "fsl,has-rstcr", so there's no compatibility reason for a misleading compatible, either. I'd go with compatible = "fsl,guts-rstcr" (what we've been using internally, and would be a nicer thing to bind against than what the kernel currently does). Or if the goal is to provide more guts registers later, use "fsl,mpc8544-guts" and have qemu log a warning if other accesses are made. -Scott