On Thu, Dec 12, 2019 at 06:33:16PM +0100, Andrew Jones wrote: > Add 5.0 machine types for arm/i440fx/q35/s390x/spapr. > > Signed-off-by: Andrew Jones <drjo...@redhat.com> > > --- > > Hi Eduardo, > > If we need to do something special for i440fx and q35, as > 9aec2e52ce9d ("hw: add compat machines for 4.2") implies, then > I'll need guidance as to what.
Keeping default_cpu_version==1 in pc-*-5.0 (like you did) is correct. However, you might want to use Cornelia's patch (which is probably already queued in the s390 tree) instead: https://patchew.org/QEMU/20191112104811.30323-1-coh...@redhat.com -- Eduardo