On 16/12/19 16:46, Juan Quintela wrote: >> I have picked up this series and rebased the -accel changes on top. > Thanks. > > about the accel and the machine type, .... it feel so weird that we only > need to add a machine type for aarch64.
Yes, it is. For now I have resolved the conflict to something like ... machine_opts = "virt,gic_ver=max"; and then if machine_opts is NULL I don't need to add "-machine" at all, so "...%s%s " ..., machine_opts ? " -machine" : NULL, machine_opts ? machine_opts : NULL, ... Paolo Paolo