On 12/17/19 7:34 AM, Philippe Mathieu-Daudé wrote:
> GCC9 is confused by this comment when building with
> CFLAG -Wimplicit-fallthrough=2:
>
> audio/audio.c: In function ‘audio_pcm_init_info’:
> audio/audio.c:306:14: error: this statement may fall through
> [-Werror=implicit-fallthrough=]
> 306 | sign = 1;
> | ~~~~~^~~
> audio/audio.c:307:5: note: here
> 307 | case AUDIO_FORMAT_U8:
> | ^~~~
> cc1: all warnings being treated as errors
>
> Add the missing fall through comment, similarly to e46349414.
...
> diff --git a/audio/audio.c b/audio/audio.c
> index 56fae55047..57daf3f620 100644
> --- a/audio/audio.c
> +++ b/audio/audio.c
> @@ -304,6 +304,7 @@ void audio_pcm_init_info (struct audio_pcm_info *info,
> struct audsettings *as)
> switch (as->fmt) {
> case AUDIO_FORMAT_S8:
> sign = 1;
> + /* fall through */
> case AUDIO_FORMAT_U8:
> mul = 1;
> break;
Reviewed-by: Richard Henderson <[email protected]>
r~
