On 18/12/19 17:59, Kevin Wolf wrote: > Am 18.12.2019 um 14:17 hat Paolo Bonzini geschrieben: >> bdrv_mark_request_serialising is writing the overlap_offset and >> overlap_bytes fields of BdrvTrackedRequest. Take bs->reqs_lock >> for the whole direction of it, and not just when waiting for > > Is "direction" really the word you meant?
No, "duration". I'll send v2 with all the fixes then. Paolo > >> serialising requests, so that tracked_request_overlaps does not >> look at a half-updated request. >> >> The new code does not unlock/relock around retries. This is unnecessary >> because a retry is always preceded by a CoQueue wait, which already >> releases and reacquired bs->reqs_lock. >> >> Reported-by: Peter Lieven <[email protected]> >> Signed-off-by: Paolo Bonzini <[email protected]> > > Reviewed-by: Kevin Wolf <[email protected]> >
