On Mon, Jun 06, 2011 at 06:04:18PM +0200, Paolo Bonzini wrote:
> +static SCSIRequest *scsi_new_request(SCSIDevice *d, DeviceState *initiator,
> + uint32_t tag, uint32_t lun)
> +{
> + SCSITargetState *s = DO_UPCAST(SCSITargetState, qdev, d);
> + SCSIRequest *req;
> + SCSITargetReq *r;
> +
> + req = scsi_req_alloc(sizeof(SCSITargetReq), &s->qdev, initiator, tag,
> lun);
> + r = DO_UPCAST(SCSITargetReq, req, req);
r not needed
> + return req;
> +}
> +
> +static void scsi_free_request(SCSIRequest *req)
> +{
> + SCSITargetReq *r = DO_UPCAST(SCSITargetReq, req, req);
> +
> + if (r->p_buf) {
> + qemu_free(r->p_buf);
> + }
qemu_free(NULL) is a nop, no need to check NULL
Stefan
